[PATCH] net: can: esd_usb2: fix memory leak on disconnect

[Alexey Khoroshilov]

It seems struct esd_usb2 dev is not deallocated on disconnect.

The patch adds the deallocation.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <***@ispras.ru>
---
drivers/net/can/usb/esd_usb2.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index b7c9e8b11460..7a90075529c3 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -1143,6 +1143,7 @@ static void esd_usb2_disconnect(struct usb_interface *intf)
}
}
unlink_all_urbs(dev);
+ kfree(dev);
}
}

[Matthias Fuchs]

Hi Alexey,

Post by Alexey Khoroshilov
It seems struct esd_usb2 dev is not deallocated on disconnect.
The patch adds the deallocation.
Found by Linux Driver Verification project (linuxtesting.org).
---
drivers/net/can/usb/esd_usb2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index b7c9e8b11460..7a90075529c3 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -1143,6 +1143,7 @@ static void esd_usb2_disconnect(struct usb_interface *intf)
}
}
unlink_all_urbs(dev);
+ kfree(dev);
}
}

thanks for pointing this out. Marc, can you please catch this up.

Matthias

Acked-by: Matthias Fuchs <***@esd.eu>
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Marc Kleine-Budde]

Post by Alexey Khoroshilov
It seems struct esd_usb2 dev is not deallocated on disconnect.
The patch adds the deallocation.
Found by Linux Driver Verification project (linuxtesting.org).

Applied to the can tree.

Thanks,
Marc